TODO.md: ten findings from a six-expert review panel #4

Open
zzg wants to merge 1 commits from todo/expert-panel-findings into main
1 Commits
Author SHA1 Message Date
zzgandClaude Opus 5 cbe6d944f9 Add TODO.md: ten findings from a six-expert review panel
Six independent reviewers (empirical rigour, security, storage/durability,
applied ML, reliability, DX) read the repo at main. The ten items here are
the findings that survived cross-checking against the source.

The two that change the most:

recoverTail (internal/store/shard.go:107-155) scans frames from offset 0,
breaks at the first CRC mismatch and unconditionally truncates, on the
assumption that only the tail can be bad. A probe flipping one bit in chunk 0
of a 10-chunk file took it from 2130 bytes to 0. A read query against a
not-yet-opened shard can trigger it.

There is no auth primitive in the repository, and the default bind is :3000 on
all interfaces, while the README instructs users to enable prompt, tool and
response content logging. The data directory is a plaintext secrets store
served to the network, with no redaction and day-granularity deletion.

go test -race ./... passes clean on all 10 packages; the suite never corrupts
a byte, fails a write, or races retention against a reader, which is where
four of these ten live.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-20 13:34:15 -07:00